luchunliang commented on code in PR #4200:
URL: https://github.com/apache/inlong/pull/4200#discussion_r914535327
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sortstandalone/SortIdInfo.java:
##########
@@ -1,10 +1,10 @@
-/*
+/**
* Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
+ * contributor license agreements. See the NOTICE file distributed with
Review Comment:
error space.
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sortstandalone/SortIdInfo.java:
##########
@@ -1,10 +1,10 @@
-/*
+/**
* Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
+ * contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
+ * the License. You may obtain a copy of the License at
Review Comment:
error space.
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sortstandalone/SortIdInfo.java:
##########
@@ -15,21 +15,19 @@
* limitations under the License.
*/
-package org.apache.inlong.manager.service.core;
+package org.apache.inlong.manager.common.pojo.sortstandalone;
-import java.util.List;
-import java.util.Map;
+import lombok.Data;
-/**
- * Sort id params service.
- */
-public interface SortTaskIdParamService {
+@Data
+public class SortIdInfo {
+ private static final long serialVersionUID = 1L;
+ String sortTaskName;
+ String inlongGroupId;
+ String inlongStreamId;
+ String extParams;
- /**
- * Select all id params by task name.
- *
- * @param taskName WorkflowTask name.
- * @return List of all id params.
- */
- List<Map<String, String>> selectByTaskName(String taskName);
+ public String getUid() {
+ return inlongGroupId.concat(inlongStreamId);
Review Comment:
absent separator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
