[GitHub] [incubator-inlong] thexiay commented on a diff in pull request #4210: [INLONG-4157][Sort] Sort lightwieght support load data to Iceberg

Mon, 16 May 2022 01:17:15 -0700 


thexiay commented on code in PR #4210:
URL: https://github.com/apache/incubator-inlong/pull/4210#discussion_r873439246


##########
pom.xml:
##########
@@ -203,8 +203,9 @@
 
         <curator.version>2.12.0</curator.version>
 
-        <avro.version>1.11.0</avro.version>
+        <avro.version>1.10.1</avro.version>

Review Comment:
   @healchow 
   in org.apache.iceberg.avro.Avro`, here it's the code.
   
   
![image](https://user-images.githubusercontent.com/37214832/168546861-f4259d8b-e771-4879-b22c-5f028259c897.png)
   
   `org.apache.avro.LogicalTypes#register` implement different in 1.10.1 and 
1.11.0.
   In 1.11.0，it will get Type Name，looks like this
   
![image](https://user-images.githubusercontent.com/37214832/168548000-81ca0c0f-193f-4791-ac59-731752e9fae5.png)
   
   
![image](https://user-images.githubusercontent.com/37214832/168547622-1cae1420-3a32-4725-863a-b222fcf85f77.png)
   
   but int 1.10.1，it will not call getTypeName, it looks like:
   
![image](https://user-images.githubusercontent.com/37214832/168549201-d779603a-ef1d-4e64-9f4a-629d08f5bc24.png)
   
   We can't solve this problem unless we modify iceberg code. Implement 
`getTypeName ` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to