This is an automated email from the ASF dual-hosted git repository.
michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new f2243b76b IMPALA-14557: Fix flaky test_show_files_partition
f2243b76b is described below
commit f2243b76b56c0a29bc252cdacec8ae53de88b327
Author: Riza Suminto <[email protected]>
AuthorDate: Mon Nov 17 09:00:58 2025 -0800
IMPALA-14557: Fix flaky test_show_files_partition
TestIcebergTable.test_show_files_partition is unstable because files are
alphanumerically sorted and the order between a random UUID and
"delete-*" is not guaranteed.
This patch fix the flakiness by specifying VERIFY_IS_SUBSET and using
negative lookahead of "delete" word to detect valid Iceberg data file.
Testing:
- Loop and pass test_show_files_partition 50 times. Before, it can fail
in less than 10 loops.
Change-Id: I6243585a5b7ab7cf7c95d5a9530ce2f2825c550e
Reviewed-on: http://gerrit.cloudera.org:8080/23680
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Michael Smith <[email protected]>
---
.../queries/QueryTest/iceberg-show-files-partition.test | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test
b/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test
index db0a18574..6ceaa1a0a 100644
---
a/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test
+++
b/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test
@@ -426,9 +426,9 @@ STRING, STRING, STRING, STRING
---- QUERY
# Show files for partition with both data and delete files
SHOW FILES IN iceberg_showfiles_with_deletes PARTITION (identity_int = 1);
----- RESULTS
+---- RESULTS: VERIFY_IS_SUBSET
row_regex:'$NAMENODE/test-warehouse/$DATABASE.db/iceberg_showfiles_with_deletes/data/identity_int=1/delete-.*_data.*.parq','.*','','$ERASURECODE_POLICY'
-row_regex:'$NAMENODE/test-warehouse/$DATABASE.db/iceberg_showfiles_with_deletes/data/identity_int=1/[^d].*_data.*.parq','.*','','$ERASURECODE_POLICY'
+row_regex:'$NAMENODE/test-warehouse/$DATABASE.db/iceberg_showfiles_with_deletes/data/identity_int=1/(?!delete).*_data.*.parq','.*','','$ERASURECODE_POLICY'
---- TYPES
STRING, STRING, STRING, STRING
====
\ No newline at end of file
