This is an automated email from the ASF dual-hosted git repository. laszlog pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 63dee747122c613fe4399c7320d5796b1b8626b4 Author: Yida Wu <[email protected]> AuthorDate: Fri Sep 26 10:22:03 2025 -0700 IMPALA-14466: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC The remote admission client's retry logic for AdmitQuery RPC did not handle cases where the admissiond restarts with a new IP address. The client would use the old proxy and retry against the old, stale ip, causing queries to time out. This change fixes the issue by adding the GetProxy() call inside the retry loop. This forces the client to re-resolve the admissiond's network address on each retry attempt, allowing it to discover the new endpoint and successfully reconnect. Tests: Passed admissiond related exhaustive ee tests. Since automatically change hosts might be difficult, manually test to change the /etc/hosts with following steps: 1. Start with --admission_service_host=localhost. 2. Change the 'localhost' in /etc/hosts to an inaccessible IP, like 127.0.0.2. 3. Submit a query, it will block in the retry logic. 4. While the query is blocked, change 'localhost' in /etc/hosts back to 127.0.0.1. 5. The query succeeded. Change-Id: I5857de84ce69902b902099f668e87d747f944aff Reviewed-on: http://gerrit.cloudera.org:8080/23472 Reviewed-by: Abhishek Rawat <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- be/src/scheduling/remote-admission-control-client.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/be/src/scheduling/remote-admission-control-client.cc b/be/src/scheduling/remote-admission-control-client.cc index 5c4c09056..c090c89c9 100644 --- a/be/src/scheduling/remote-admission-control-client.cc +++ b/be/src/scheduling/remote-admission-control-client.cc @@ -139,6 +139,9 @@ Status RemoteAdmissionControlClient::SubmitForAdmission( VLOG(3) << "Retrying AdmitQuery rpc for " << request.query_id << ". Previous rpc failed with status: " << admit_rpc_status.ToString(); + // Re-resolve the admissiond address on each retry to handle cases + // where the admissiond has restarted with a new IP. + RETURN_IF_ERROR(AdmissionControlService::GetProxy(&proxy)); admit_status = TryAdmitQuery(proxy.get(), request.request, &req, &admit_rpc_status); }
