This is an automated email from the ASF dual-hosted git repository. jasonmfehr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 8d663765d7a8f4793bf69baa024f753f9ea4a4a3 Author: jasonmfehr <[email protected]> AuthorDate: Tue Sep 2 11:08:01 2025 -0700 IMPALA-14382: Fix Null Pointer Dereference Fixes a potential null pointer dereference when log level >= 2. Adds 'build' as a valid EE test helper directory as VSCode creates this directory. Tested locally by running test_scanners from the query_test EE test suite using a release build of Impala and log level 2. Minidumps were not generated during this test run but were generated during the same test run without this fix applied. Generated-by: Github Copilot (Claude Sonnet 3.7) Change-Id: I91660aa84407c17ffb7cd3c721d4f3f0a844d61d Reviewed-on: http://gerrit.cloudera.org:8080/23365 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- be/src/exec/base-sequence-scanner.cc | 3 ++- tests/.gitignore | 1 + tests/run-tests.py | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/be/src/exec/base-sequence-scanner.cc b/be/src/exec/base-sequence-scanner.cc index ca7034403..f288342de 100644 --- a/be/src/exec/base-sequence-scanner.cc +++ b/be/src/exec/base-sequence-scanner.cc @@ -122,7 +122,8 @@ Status BaseSequenceScanner::Open(ScannerContext* context) { void BaseSequenceScanner::Close(RowBatch* row_batch) { DCHECK(!is_closed_); - VLOG_FILE << "Bytes read past scan range: " << -stream_->bytes_left(); + VLOG_FILE << "Bytes read past scan range: " << (stream_ == nullptr ? 0 : + -stream_->bytes_left()); VLOG_FILE << "Average block size: " << (num_syncs_ > 1 ? total_block_size_ / (num_syncs_ - 1) : 0); // Need to close the decompressor before releasing the resources at AddFinalRowBatch(), diff --git a/tests/.gitignore b/tests/.gitignore index 3e37ef877..063e73a0e 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -1,5 +1,6 @@ results build +build/ aux_* .cache results diff --git a/tests/run-tests.py b/tests/run-tests.py index 335d88c4c..56a2602df 100755 --- a/tests/run-tests.py +++ b/tests/run-tests.py @@ -45,7 +45,7 @@ VALID_TEST_DIRS = ['failure', 'query_test', 'stress', 'unittests', 'aux_query_te # new dir to the list of valid test dirs above. All dirs unders tests/ must be placed # into one of these lists, otherwise the script will throw an error. This list can be # removed once IMPALA-4417 has been resolved. -TEST_HELPER_DIRS = ['aux_parquet_data_load', 'comparison', 'benchmark', +TEST_HELPER_DIRS = ['aux_parquet_data_load', 'comparison', 'benchmark', 'build', 'custom_cluster', 'util', 'experiments', 'verifiers', 'common', 'performance', 'beeswax', 'aux_custom_cluster_tests', 'authorization', 'test-hive-udfs', '__pycache__', 'webui']
