This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 6b005a793a3b22de803429e4867f1459d72c236a
Author: Riza Suminto <[email protected]>
AuthorDate: Sun Aug 10 21:56:43 2025 -0700

    IMPALA-14296: Fix with_args fixture in TestMetadataReplicas
    
    IMPALA-13947 has incorrect fixture edit that cause following error:
    
    common/custom_cluster_test_suite.py:396: in setup_method
        pytest.fail("Cannot specify with_args on both class and methods")
    E   Failed: Cannot specify with_args on both class and methods
    
    This patch move the with_args fixture at test_catalog_restart up to the
    class level.
    
    Testing:
    Run and pass TestMetadataReplicas in exhaustive mode.
    
    Change-Id: I9016eac859fb01326b3d1e0a8e8e135f03d696bb
    Reviewed-on: http://gerrit.cloudera.org:8080/23280
    Reviewed-by: Quanlong Huang <[email protected]>
    Reviewed-by: Xuebin Su <[email protected]>
    Tested-by: Quanlong Huang <[email protected]>
---
 tests/custom_cluster/test_metadata_replicas.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/custom_cluster/test_metadata_replicas.py 
b/tests/custom_cluster/test_metadata_replicas.py
index e67ddb93e..2a1dd3dfb 100644
--- a/tests/custom_cluster/test_metadata_replicas.py
+++ b/tests/custom_cluster/test_metadata_replicas.py
@@ -26,7 +26,8 @@ from tests.util.hive_utils import HiveDbWrapper
 @SkipIfFS.hive
 @CustomClusterTestSuite.with_args(
     impalad_args="--use_local_catalog=false",
-    catalogd_args="--catalog_topic_mode=full")
+    catalogd_args="--catalog_topic_mode=full",
+    statestored_args="--statestore_update_frequency_ms=1000")
 class TestMetadataReplicas(CustomClusterTestSuite):
   """ Validates metadata content across catalogd and impalad coordinators.
   This test is only valid in legacy catalog mode. """
@@ -44,8 +45,6 @@ class TestMetadataReplicas(CustomClusterTestSuite):
     self.__validate_metadata()
 
   @pytest.mark.execute_serially
-  @CustomClusterTestSuite.with_args(
-      statestored_args="--statestore_update_frequency_ms=1000")
   def test_catalog_restart(self, testid_checksum):
     """ IMPALA-6948: reproduces the issue by deleting a table from Hive while 
the catalogd
         is down. When catalogd is restarted, if the regression is present, the 
deleted

Reply via email to