This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 5414c3009 IMPALA-13809: Update list of excluded locations for the code
coverage report
5414c3009 is described below
commit 5414c3009890a736901b6ae3b56b9953b1992de7
Author: Joe McDonnell <[email protected]>
AuthorDate: Wed Feb 26 09:53:57 2025 -0800
IMPALA-13809: Update list of excluded locations for the code coverage report
This adds be/src/gutil and be/src/kudu to the list of excluded
locations for the code coverage report. These directories are third-party
party code that have been vendored into the Impala repository. There
is a fair amount of unused code in those directories simply because it
is easier to maintain that way. Impala's tests aren't intending to test
that code.
Testing:
- Ran code coverage with the updated list
Change-Id: I7f3aa971e50b2c454e9ca607fb9d49d7cc3593ae
Reviewed-on: http://gerrit.cloudera.org:8080/23084
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
bin/coverage_helper.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bin/coverage_helper.sh b/bin/coverage_helper.sh
index 2a50e3bbc..f6a78f9ea 100755
--- a/bin/coverage_helper.sh
+++ b/bin/coverage_helper.sh
@@ -77,6 +77,8 @@ if [ ${REPORT_ACTION} -eq 1 ]; then
cd "${IMPALA_HOME}"
"${IMPALA_HOME}/bin/impala-gcovr" -v -r "${IMPALA_HOME}/be" \
--exclude=".*src/benchmarks.*" \
+ --exclude=".*src/gutil.*" \
+ --exclude=".*src/kudu.*" \
--exclude=".*generated-sources/gen-cpp.*" \
--exclude=".*src/util/bit-packing.inline.h.*" \
--html --html-details -o "${REPORT_DIRECTORY}/index.html" \
