This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 1ae97e717 IMPALA-13811: Deflake test_insert_overwrite_base_detection
1ae97e717 is described below

commit 1ae97e7173da3b9c9df7262dcc4a1e0b3f409073
Author: Csaba Ringhofer <[email protected]>
AuthorDate: Wed Jul 16 19:12:39 2025 +0200

    IMPALA-13811: Deflake test_insert_overwrite_base_detection
    
    The test didn't wait in wait_for_finished_timeout() long
    enough and ignored its return value, so it could continue
    execution before the query was actually finished.
    
    Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
    Reviewed-on: http://gerrit.cloudera.org:8080/23180
    Reviewed-by: Riza Suminto <[email protected]>
    Tested-by: Impala Public Jenkins <[email protected]>
---
 tests/query_test/test_acid.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/query_test/test_acid.py b/tests/query_test/test_acid.py
index 277bd2da1..a0b5783ff 100644
--- a/tests/query_test/test_acid.py
+++ b/tests/query_test/test_acid.py
@@ -382,7 +382,8 @@ class TestAcid(ImpalaTestSuite):
     self.execute_query('insert into %s partition (p="b") values (4)' % tbl)
     result = self.execute_query("select * from %s order by i" % tbl)
     assert result.data == ['3\tb', '4\tb']
-    self.client.wait_for_finished_timeout(
-        other_partition_insert_handle, 0.001 * sleep_time_ms)
+    # Wait 2*sleep_time_ms.
+    assert self.client.wait_for_finished_timeout(
+        other_partition_insert_handle, 0.001 * 2 * sleep_time_ms)
     result = self.execute_query("select * from %s order by i" % tbl)
     assert result.data == ['1\ta', '3\tb', '4\tb']

Reply via email to