This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit d36df0eb8847d527eeb4c62feb8a78a322605a3e Author: Riza Suminto <[email protected]> AuthorDate: Mon Jun 23 12:58:47 2025 -0700 IMPALA-14163: Raise test_pool_config_change_while_queued MEM_LIMIT test_pool_config_change_while_queued hit timeout at TestAdmissionControllerWithACService. When running this test locally, we notice that some trigger query ("select 'wait_for_config_change'") passed when it is expected to be rejected (hit EXCEPTION during admission). This patch increase the MEM_LIMIT higher to 128GB to ensure rejection. It also add wait_for_admission_control() that should immediately return once trigger query hit exception. Removed redundant "set enable_trivial_query_for_admission=false" query in test_pool_config_change_while_queued. Testing: - Loop the test couple times and confirm that all trigger query executions hit exception. Change-Id: Iee808d0fc92308604ed0ee27dde795e9aa69eb5d Reviewed-on: http://gerrit.cloudera.org:8080/23072 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/common/resource_pool_config.py | 5 +++-- tests/custom_cluster/test_admission_controller.py | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/common/resource_pool_config.py b/tests/common/resource_pool_config.py index 0c53bbdf0..e2ace0115 100644 --- a/tests/common/resource_pool_config.py +++ b/tests/common/resource_pool_config.py @@ -65,12 +65,13 @@ class ResourcePoolConfig(object): client.set_configuration_option('request_pool', pool_name) # set mem_limit to something above the proc limit so that the query always gets # rejected. - client.set_configuration_option('mem_limit', '20G') + client.set_configuration_option('mem_limit', '128G') + client.set_configuration_option("enable_trivial_query_for_admission", "false") metric_key = "admission-controller.{0}.root.{1}".format(metric_str, pool_name) start_time = time() while (time() - start_time < timeout): - client.execute("set enable_trivial_query_for_admission=false") handle = client.execute_async("select 'wait_for_config_change'") + client.wait_for_admission_control(handle, timeout) client.close_query(handle) current_val = str(self.ac_service.get_metric_value(metric_key)) if current_val == target_val: diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py index 92e6d5eaf..358424012 100644 --- a/tests/custom_cluster/test_admission_controller.py +++ b/tests/custom_cluster/test_admission_controller.py @@ -1472,7 +1472,6 @@ class TestAdmissionController(TestAdmissionControllerBase): self.client.wait_for_admission_control(sleep_query_handle) self._wait_for_change_to_profile(sleep_query_handle, "Admission result: Admitted immediately") - self.client.execute("set enable_trivial_query_for_admission=false") queued_query_handle = self.client.execute_async("select 2") self._wait_for_change_to_profile(queued_query_handle, "Admission result: Queued")
