This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 9a1021389 IMPALA-14141 (Addendum): Restore Hive compactor settings
after HIVE-28662
9a1021389 is described below
commit 9a10213891d9d3b02a80aa9376b61396bb0cc32f
Author: Fang-Yu Rao <[email protected]>
AuthorDate: Mon Jun 23 20:42:49 2025 -0700
IMPALA-14141 (Addendum): Restore Hive compactor settings after HIVE-28662
This patch restores Hive compactor settings that were changed in
HIVE-28662 but not in IMPALA-14141. Without the addendum, some tests
like testAcidMinorCompactionLoading() could still fail.
Note that this doesn't change the value for
metastore.housekeeping.leader.election that was also changed in
HIVE-28662, as that doesn't control compaction and either values works.
Change-Id: Ifd651aeacf3deba1a8272803207192d5da32a2e4
Reviewed-on: http://gerrit.cloudera.org:8080/23082
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
fe/src/test/resources/hive-site.xml.py | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/fe/src/test/resources/hive-site.xml.py
b/fe/src/test/resources/hive-site.xml.py
index dfb5d51c3..d3a3609b4 100644
--- a/fe/src/test/resources/hive-site.xml.py
+++ b/fe/src/test/resources/hive-site.xml.py
@@ -191,8 +191,17 @@ if HIVE_MAJOR_VERSION >= 3:
# Disable auto compaction of Hive Metastore after HIVE-28662 to prevent
Hive from
# automatically compacting files associated with ACID tables, which could
make some
# test cases non-deterministic, e.g., those in acid.test.
- 'hive.compactor.initiator.on': 'false'
+ 'hive.compactor.initiator.on': 'false',
+ 'hive.compactor.cleaner.on': 'false'
})
+ # 'hive.metastore.housekeeping.threads.on' was also set to true by default in
+ # HIVE-28662. But since IMPALA-12827 requires that this configuration be
true when
+ # 'VARIANT' is 'housekeeping_on', we set this configuration to true only if
+ # 'VARIANT' is not 'housekeeping_on'.
+ if VARIANT != 'housekeeping_on':
+ CONFIG.update({
+ 'hive.metastore.housekeeping.threads.on': 'false'
+ })
else:
CONFIG.update({
# HMS-2 based environments have a different set of expected configurations
for event processor
