This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit c45e3e796883d998dc982c62e8a99d601a29b94d Author: Csaba Ringhofer <[email protected]> AuthorDate: Fri May 30 15:42:04 2025 +0200 IMPALA-14109: Remove SkipIfCatalogV2.hms_event_polling_disabled This skipIf used the coordinator webui to check whether the flag is set and skipped the test if the cluster was not running. The skipIf was only used in custom cluster tests where the cluster is restarted with new flags anyway, so the flags of the previous cluster are not relevant. Change-Id: I455b39eff95e45d02c7b9e0b35d8e7fe03145bb1 Reviewed-on: http://gerrit.cloudera.org:8080/22960 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/common/skip.py | 7 ------- tests/custom_cluster/test_event_processing_error.py | 2 +- tests/metadata/test_event_processing.py | 2 -- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/common/skip.py b/tests/common/skip.py index d26b66b09..6d3a8b182 100644 --- a/tests/common/skip.py +++ b/tests/common/skip.py @@ -261,13 +261,6 @@ class SkipIfCatalogV2: IMPALA_TEST_CLUSTER_PROPERTIES.is_catalog_v2_cluster(), reason="Table isn't invalidated with Local catalog and enabled hms_event_polling.") - @classmethod - def hms_event_polling_disabled(self): - return pytest.mark.skipif( - not IMPALA_TEST_CLUSTER_PROPERTIES.is_event_polling_enabled(), - reason="Test expects event polling to be enabled.") - - class SkipIfApacheHive(): feature_not_supported = pytest.mark.skipif(IS_APACHE_HIVE, reason="Apache Hive does not support this feature") diff --git a/tests/custom_cluster/test_event_processing_error.py b/tests/custom_cluster/test_event_processing_error.py index 7dfe1d195..49d5e9b10 100644 --- a/tests/custom_cluster/test_event_processing_error.py +++ b/tests/custom_cluster/test_event_processing_error.py @@ -26,7 +26,7 @@ from tests.util.acid_txn import AcidTxn from tests.util.event_processor_utils import EventProcessorUtils [email protected]_event_polling_disabled() [email protected] class TestEventProcessingError(CustomClusterTestSuite): """ Tests for verify event processor not going into error state whenever there are diff --git a/tests/metadata/test_event_processing.py b/tests/metadata/test_event_processing.py index cc297477a..1b05c146a 100644 --- a/tests/metadata/test_event_processing.py +++ b/tests/metadata/test_event_processing.py @@ -35,7 +35,6 @@ PROCESSING_TIMEOUT_S = 10 LOG = logging.getLogger(__name__) @SkipIfFS.hive [email protected]_event_polling_disabled() class TestEventProcessing(ImpalaTestSuite): """This class contains tests that exercise the event processing mechanism in the catalog.""" @@ -314,7 +313,6 @@ class TestEventProcessing(ImpalaTestSuite): @SkipIfFS.hive [email protected]_event_polling_disabled() class TestEventSyncWaiting(ImpalaTestSuite): """Verify query option sync_hms_events_wait_time_s should protect the query by waiting until Impala sync the HMS changes."""
