This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 71b47dfdb483867f4a1ec5e250904659510e0ea8 Author: Joe McDonnell <[email protected]> AuthorDate: Tue May 27 15:23:28 2025 -0700 IMPALA-14103: Fix TestAdmissionControllerStress on Python 3 TestAdmissionControllerStress has an invalid except clause where it catches Exception as well as ImpalaHiveServer2Service. This is an error on Python 3, because ImpalaHiveServer2Service is not an exception class. This changes the except clause to only cause Exception. Testing: - Ran TestAdmissionControllerStress locally Change-Id: Iefe9306cd6b76bd27ca5be1d62b05aff1e5deafe Reviewed-on: http://gerrit.cloudera.org:8080/22954 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- tests/custom_cluster/test_admission_controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py index 8f70e03ff..aa20a5dda 100644 --- a/tests/custom_cluster/test_admission_controller.py +++ b/tests/custom_cluster/test_admission_controller.py @@ -2613,7 +2613,7 @@ class TestAdmissionControllerStress(TestAdmissionControllerBase): # try fetch and confirm from exception message that query was timed out. client.fetch(query, query_handle, discard_results=True) assert False - except (Exception, ImpalaHiveServer2Service) as e: + except Exception as e: assert 'expired due to client inactivity' in str(e) elif self.query_end_behavior == 'EOS': # Fetch all rows so we hit eos.
