This is an automated email from the ASF dual-hosted git repository.

dbecker pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 125df65322ad9a9c591d7614fbc2f9d5e82caa53
Author: Riza Suminto <[email protected]>
AuthorDate: Wed May 21 08:11:56 2025 -0700

    IMPALA-14042: (Addendum) limit test_rename_drop in exhaustive mode
    
    test_rename_drop continues to be flaky in non-HDFS environment. HMS
    seems to be slower to response in non-HDFS environment. There are also
    possibillity of table lock contention with background TableLoader and
    CatalogDelta thread that cause DROP query happen after RENAME instead of
    BEFORE.
    
    This patch limit running test_rename_drop in HDFS and exhaustive mode in
    the meantime.
    
    Change-Id: Ie55e6d6093367c454cf3e31ed8a409b6e091193d
    Reviewed-on: http://gerrit.cloudera.org:8080/22933
    Reviewed-by: Impala Public Jenkins <[email protected]>
    Tested-by: Michael Smith <[email protected]>
---
 tests/custom_cluster/test_concurrent_rename.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/custom_cluster/test_concurrent_rename.py 
b/tests/custom_cluster/test_concurrent_rename.py
index 4f910c71c..ada56605d 100644
--- a/tests/custom_cluster/test_concurrent_rename.py
+++ b/tests/custom_cluster/test_concurrent_rename.py
@@ -16,10 +16,13 @@
 # under the License.
 
 from __future__ import absolute_import, division, print_function
+from copy import deepcopy
 import time
 
-from copy import deepcopy
+import pytest
+
 from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
+from tests.util.filesystem_utils import IS_HDFS
 
 
 @CustomClusterTestSuite.with_args(
@@ -31,7 +34,11 @@ from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite
 class TestConcurrentRename(CustomClusterTestSuite):
   """Test concurrent rename with invalidate and other DDLs."""
 
+  @pytest.mark.skipif(
+      not IS_HDFS, reason="Test is not deterministic in non-HDFS environment")
   def test_rename_drop(self, vector, unique_database):
+    if self.exploration_strategy() != 'exhaustive':
+      pytest.skip('runs only in exhaustive')
     catalogd = self.cluster.catalogd
     name = "{}.tbl".format(unique_database)
     self.execute_query("create table {} (s string)".format(name))

Reply via email to