This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 665601606937dee68517f3dba88d9f543b0d9f2d Author: Surya Hebbar <[email protected]> AuthorDate: Sat May 3 03:40:53 2025 +0530 IMPALA-14032: Fix broken query timeline after webUI refactor in IMPALA-13389 Updated the identifiers in the following query timeline script according to the new declrations. Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9 Reviewed-on: http://gerrit.cloudera.org:8080/22857 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Riza Suminto <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- www/scripts/query_timeline/fragment_diagram.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/scripts/query_timeline/fragment_diagram.js b/www/scripts/query_timeline/fragment_diagram.js index 74ab0123b..7fb0f7157 100644 --- a/www/scripts/query_timeline/fragment_diagram.js +++ b/www/scripts/query_timeline/fragment_diagram.js @@ -198,7 +198,7 @@ function DrawBars(svg, rownum, row_height, events, xoffset, px_per_ns) { // } const BAR_HEIGHT = row_height - 2; const LAST_E_INDEX = events.length - 1; - const LAST_TS_INDEX = events[last_e_index].ts_list.length - 1; + const LAST_TS_INDEX = events[LAST_E_INDEX].ts_list.length - 1; let plan_node = getSvgGroup(); plan_node.classList.add("plan_node"); // coordinates start with (0,0) in the top-left corner @@ -275,15 +275,15 @@ function DrawBars(svg, rownum, row_height, events, xoffset, px_per_ns) { let top_edge_ts, bottom_edge_ts; if (bucketed) { top_edge_ts = events[LAST_E_INDEX].parts[0].max; - bottom_edge_ts = events[LAST_E_INDEX].parts[bucket_size - 1].max; + bottom_edge_ts = events[LAST_E_INDEX].parts[BUCKET_SIZE - 1].max; } else { top_edge_ts = events[LAST_E_INDEX].ts_list[0]; bottom_edge_ts = events[LAST_E_INDEX].ts_list[LAST_TS_INDEX]; } plan_node.appendChild(getSvgLine(stroke_fill_colors.black, xoffset, y, xoffset + top_edge_ts * px_per_ns, y, false)); - plan_node.appendChild(getSvgLine(stroke_fill_colors.black, xoffset, y + bar_height, - xoffset + bottom_edge_ts * px_per_ns, y + bar_height, + plan_node.appendChild(getSvgLine(stroke_fill_colors.black, xoffset, y + BAR_HEIGHT, + xoffset + bottom_edge_ts * px_per_ns, y + BAR_HEIGHT, false)); }
