This is an automated email from the ASF dual-hosted git repository. boroknagyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit b9c074d283112abf08f1e63c1e886d35662b80e2 Author: Riza Suminto <[email protected]> AuthorDate: Wed Apr 2 13:10:10 2025 -0700 IMPALA-13926: Remove teardown in TestWorkloadManagementInitNoWait test_start_invalid_version and test_start_unknown_version of TestWorkloadManagementInitNoWait hit assertion error during teardown. These tests are set up with expect_startup_fail=True. This patch attempts to deflake the issue by removing the teardown_method() and moves wait_for_wm_idle() at the end of tests that are not set up with expect_startup_fail=True. Testing: Loop TestWorkloadManagementInitNoWait 10 times and pass them all. Change-Id: I03c748dc100f5447820a9a77c527facb832521d6 Reviewed-on: http://gerrit.cloudera.org:8080/22725 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/custom_cluster/test_workload_mgmt_init.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/custom_cluster/test_workload_mgmt_init.py b/tests/custom_cluster/test_workload_mgmt_init.py index 45ef09bd5..531fdfd9f 100644 --- a/tests/custom_cluster/test_workload_mgmt_init.py +++ b/tests/custom_cluster/test_workload_mgmt_init.py @@ -529,10 +529,6 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase): def setup_method(self, method): super(TestWorkloadManagementInitNoWait, self).setup_method(method) - def teardown_method(self, method): - self.wait_for_wm_idle() - super(TestWorkloadManagementInitNoWait, self).teardown_method(method) - @CustomClusterTestSuite.with_args( cluster_size=1, log_symlinks=True, impalad_args="--query_log_write_interval_s=3", @@ -562,6 +558,7 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase): res = self.client.execute("select * from functional.alltypes") assert res.success impalad.wait_for_metric_value("impala-server.completed-queries.written", 1, 15) + self.wait_for_wm_idle() @CustomClusterTestSuite.with_args( cluster_size=1, expect_startup_fail=True, @@ -617,6 +614,7 @@ class TestWorkloadManagementInitNoWait(TestWorkloadManagementInitBase): # Assert the standby catalog skipped workload management initialization. self.assert_catalogd_log_contains("INFO", r"workload management initialization", expected_count=0, node_index=1) + self.wait_for_wm_idle() class TestWorkloadManagementCatalogHA(TestWorkloadManagementInitBase):
