This is an automated email from the ASF dual-hosted git repository. csringhofer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit ad124d1dba77a223ea7360e9be06d9e0a775fb05 Author: Riza Suminto <[email protected]> AuthorDate: Tue Mar 18 08:19:56 2025 -0700 IMPALA-13872: Deflake test_query_cpu_count_divisor_default assertion IMPALA-13333 adds test that assert the value of "Cluster Memory Admitted" counter. However, this counter can have slightly different value depending of target filesystem (HDFS, Ozone, S3). This cause flakiness in test_query_cpu_count_divisor_default. This patch remove such assertion from test_query_cpu_count_divisor_default. The remaining assertion is sufficient to ensure correctness of system under test. Testing: - Run and pass test_query_cpu_count_divisor_default. Change-Id: I676ee31728de2886acc72d11b8ece14f0238814b Reviewed-on: http://gerrit.cloudera.org:8080/22636 Reviewed-by: Daniel Becker <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/custom_cluster/test_executor_groups.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/custom_cluster/test_executor_groups.py b/tests/custom_cluster/test_executor_groups.py index 70a11a3c2..af08f4890 100644 --- a/tests/custom_cluster/test_executor_groups.py +++ b/tests/custom_cluster/test_executor_groups.py @@ -1324,7 +1324,6 @@ class TestExecutorGroups(CustomClusterTestSuite): "Per-Host Resource Estimates: Memory=9.25GB", "mem-estimate=1.38GB", # memory estimate of 17:AGGREGATE. "mem-estimate=1.11GB", # memory estimate of 07:AGGREGATE. - "Cluster Memory Admitted: 10.90 GB", "MemoryAsk: 27.76 GB"]) # Set very low MEM_ESTIMATE_SCALE_FOR_SPILLING_OPERATOR. @@ -1335,7 +1334,6 @@ class TestExecutorGroups(CustomClusterTestSuite): "Per-Host Resource Estimates: Memory=1.86GB", "mem-estimate=210.92MB", # memory estimate of 17:AGGREGATE. "mem-estimate=211.13MB", # memory estimate of 07:AGGREGATE. - "Cluster Memory Admitted: 6.07 GB", "MemoryAsk: 5.57 GB"]) # Set MEM_ESTIMATE_SCALE_FOR_SPILLING_OPERATOR to maximum. @@ -1346,7 +1344,6 @@ class TestExecutorGroups(CustomClusterTestSuite): "Per-Host Resource Estimates: Memory=9.25GB", "mem-estimate=1.38GB", # memory estimate of 17:AGGREGATE. "mem-estimate=1.11GB", # memory estimate of 07:AGGREGATE. - "Cluster Memory Admitted: 10.90 GB", "MemoryAsk: 27.76 GB"]) # Set MEM_LIMIT_EXECUTORS to 3GB, lower than --mem_limit=4g of root.large's @@ -1358,7 +1355,6 @@ class TestExecutorGroups(CustomClusterTestSuite): "Per-Host Resource Estimates: Memory=6.68GB", "mem-estimate=1.00GB", # memory estimate of 17:AGGREGATE. "mem-estimate=768.00MB", # memory estimate of 07:AGGREGATE. - "Cluster Memory Admitted: 9.10 GB", "MemoryAsk: 20.03 GB"]) # Set MEM_LIMIT to 2GB, lower than MEM_LIMIT_EXECUTORS. @@ -1369,7 +1365,6 @@ class TestExecutorGroups(CustomClusterTestSuite): "Per-Host Resource Estimates: Memory=4.68GB", "mem-estimate=682.67MB", # memory estimate of 17:AGGREGATE. "mem-estimate=512.00MB", # memory estimate of 07:AGGREGATE. - "Cluster Memory Admitted: 8.00 GB", "MemoryAsk: 14.03 GB"]) self._set_query_options({
