This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 4aea5d6923bb5aac8423295b918c59bac9fcaf9c
Author: Riza Suminto <[email protected]>
AuthorDate: Fri Feb 7 11:44:54 2025 -0800

    IMPALA-13743: Fix setup_method calls at test_admission_controller.py
    
    IMPALA-13694 reveals an issue in setup_method calls of
    TestAdmissionControllerWithACService and
    TestAdmissionControllerStressWithACService. They should be called with
    their own class name instead of the superclass name.
    
    Testing:
    - Pass TestAdmissionControllerWithACService and
      TestAdmissionControllerStressWithACService in exhaustive exploration.
    
    Change-Id: I092c4f397cba1908245ccb30111176190b2182ff
    Reviewed-on: http://gerrit.cloudera.org:8080/22465
    Reviewed-by: Jason Fehr <[email protected]>
    Tested-by: Impala Public Jenkins <[email protected]>
---
 tests/custom_cluster/test_admission_controller.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/custom_cluster/test_admission_controller.py 
b/tests/custom_cluster/test_admission_controller.py
index fcd0ee8b3..c38cf0718 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -1795,7 +1795,7 @@ class 
TestAdmissionControllerWithACService(TestAdmissionController):
     method.__dict__[START_ARGS] = start_args
     if IMPALAD_ARGS in method.__dict__:
       method.__dict__[ADMISSIOND_ARGS] = method.__dict__[IMPALAD_ARGS]
-    super(TestAdmissionController, self).setup_method(method)
+    super(TestAdmissionControllerWithACService, self).setup_method(method)
 
   @SkipIfNotHdfsMinicluster.tuned_for_minicluster
   @pytest.mark.execute_serially
@@ -2617,4 +2617,4 @@ class 
TestAdmissionControllerStressWithACService(TestAdmissionControllerStress):
     method.__dict__[START_ARGS] = start_args
     if IMPALAD_ARGS in method.__dict__:
       method.__dict__[ADMISSIOND_ARGS] = method.__dict__[IMPALAD_ARGS]
-    super(TestAdmissionControllerStress, self).setup_method(method)
+    super(TestAdmissionControllerStressWithACService, 
self).setup_method(method)

Reply via email to