This is an automated email from the ASF dual-hosted git repository. asherman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 2bffca10292aa93e00819ed07860f99b7d10b8c4 Author: Sai Hemanth Gantasala <[email protected]> AuthorDate: Tue Nov 19 22:34:56 2024 -0800 IMPALA-13500: Fix test_invalidate_stale_partition_on_reload() test TestEventProcessingCustomConfigs#test_invalidate_stale_partition_on _reload() is flaky for not finding log lines it is looking for. This is happening because ParallelFileMetadataLoader which is running in the background thread is missing the current catalog delta request, hence the log lines are not visible in impala logs. The next catalog delta request writes the required log lines to impala logs but the test fails by that time. Adding a sleep 5s should finish the file metadata reload and also increased the timeout from 6s to 15s to verify the impala log then catalog delta request can capture the required content. Testing: - Looped the test several hundred times locally to verify that their is no flakiness. Change-Id: I62170aa6ed8ae122482a03212fec9c4fe843ce03 Reviewed-on: http://gerrit.cloudera.org:8080/22084 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/custom_cluster/test_events_custom_configs.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/custom_cluster/test_events_custom_configs.py b/tests/custom_cluster/test_events_custom_configs.py index 6a1062c13..adf30b18c 100644 --- a/tests/custom_cluster/test_events_custom_configs.py +++ b/tests/custom_cluster/test_events_custom_configs.py @@ -1325,9 +1325,12 @@ class TestEventProcessingCustomConfigs(TestEventProcessingCustomConfigsBase): EventProcessorUtils.wait_for_event_processing(self) log_regex = r"Invalidated objects in cache: \[partition %s:p=\d \(id=%%d\)\]" \ % test_tbl - self.assert_impalad_log_contains('INFO', log_regex % 0) - self.assert_impalad_log_contains('INFO', log_regex % 1) - self.assert_impalad_log_contains('INFO', log_regex % 2) + self.assert_impalad_log_contains('INFO', log_regex % 0, expected_count=1, + timeout_s=20) + self.assert_impalad_log_contains('INFO', log_regex % 1, expected_count=1, + timeout_s=20) + self.assert_impalad_log_contains('INFO', log_regex % 2, expected_count=1, + timeout_s=20) @SkipIfFS.hive
