This is an automated email from the ASF dual-hosted git repository.
michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 6a2f5da59 IMPALA-13383: Fix
TestIcebergTable.test_create_table_like_table exhaustive test failure
6a2f5da59 is described below
commit 6a2f5da59c2241644b10a2e8a1e26cecbf3f6e87
Author: Noemi Pap-Takacs <[email protected]>
AuthorDate: Fri Nov 15 16:44:59 2024 +0100
IMPALA-13383: Fix TestIcebergTable.test_create_table_like_table exhaustive
test failure
TestIcebergTable.test_create_table_like_table contained 2 tables
that were created in the default Hadoop Catalog location:
'iceberg.catalog_location' = 'ice_hadoop_cat'.
As a result of this, the tables were created under the path defined in
hive-site.xml.py and not in the unique database directory.
They both had a constant string as the table identifier that was
concatenated to the catalog location to form the table's path.
When the test was run in parallel, it failed with AlreadyExistsException
because all tests created the table with the same name in the same
directory.
Fix: Added unique database to the table identifier so that it became
unique and the tables are stored in separate directories.
Testing:
- Ran TestIcebergTable.test_create_table_like_table locally
in exhaustive mode multiple times before and after the fix.
Command:
'tests/run-tests.py
--workload_exploration_strategy=functional-query:exhaustive
query_test/test_iceberg.py::TestIcebergTable::test_create_table_like_table'
Change-Id: I1d70855f37aae06cc2b8e59fb773013e2b3918a8
Reviewed-on: http://gerrit.cloudera.org:8080/22072
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
.../queries/QueryTest/iceberg-create-table-like-table.test | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
b/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
index c8e8c6641..eb67cee4d 100644
---
a/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
+++
b/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
@@ -397,7 +397,7 @@ create table ice_hadoop_cat_no_part(
array < STRING > >
) stored as iceberg tblproperties(
'iceberg.catalog' = 'ice_hadoop_cat',
- 'iceberg.table_identifier' = 'id_a.id_b.ice_hadoop_cat_no_part'
+ 'iceberg.table_identifier' = 'id_a.$DATABASE.ice_hadoop_cat_no_part'
);
---- RESULTS
'Table has been created.'
@@ -460,7 +460,7 @@ create table ice_hadoop_cat(
array < STRING > >
) partitioned by spec (bucket(3, id)) stored as iceberg tblproperties(
'iceberg.catalog' = 'ice_hadoop_cat',
- 'iceberg.table_identifier' = 'id_a.id_b.ice_hadoop_cat'
+ 'iceberg.table_identifier' = 'id_a.$DATABASE.ice_hadoop_cat'
);
---- RESULTS
'Table has been created.'
