This is an automated email from the ASF dual-hosted git repository.

michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit ae14d78c8f2e8366e67aa8c39f0c02c60862905e
Author: Michael Smith <[email protected]>
AuthorDate: Mon Sep 25 11:17:27 2023 -0700

    IMPALA-12464: Add opens for java.util.regex
    
    Adds --add-opens for java.util.regex with jamm for JDK 17. Java 15 added
    hidden classes to define lambdas, and Jamm is unable to access fields of
    hidden classes unless add-opens is added for the class.
    
    Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
    Reviewed-on: http://gerrit.cloudera.org:8080/20510
    Reviewed-by: Impala Public Jenkins <[email protected]>
    Tested-by: Michael Smith <[email protected]>
---
 be/src/common/init.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/be/src/common/init.cc b/be/src/common/init.cc
index 3409dde52..300996a35 100644
--- a/be/src/common/init.cc
+++ b/be/src/common/init.cc
@@ -376,9 +376,10 @@ static Status JavaAddOpens(bool useSizeOf) {
   }
 
   for (const string& param : {
-    // Needed for jamm and ehcache
+    // Needed for jamm and ehcache (jamm needs it to access lambdas)
     "--add-opens=java.base/java.lang=ALL-UNNAMED",
     "--add-opens=java.base/java.nio=ALL-UNNAMED",
+    "--add-opens=java.base/java.util.regex=ALL-UNNAMED",
     "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
   }) {
     val_out << " " << param;

Reply via email to