This is an automated email from the ASF dual-hosted git repository.

laszlog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 4a153792d IMPALA-12185: Don't install snappy-devel for Red Hat 
derivatives
4a153792d is described below

commit 4a153792deba2b2861347ec0e016460f7115e0f1
Author: Laszlo Gaal <[email protected]>
AuthorDate: Wed Jun 7 16:43:12 2023 +0200

    IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
    
    Experimental builds on systems based on Red Hat Linux v8.x revealed that
    snappy-devel is installed only for RedHat-based systems in
    bin/bootstrap_system.sh (the script that preps a workstation for local
    Impala development). The same library was not installed for Ubuntu
    variants -- probably because Impala has been using Snappy from the
    toolchain for a long time now.
    
    Subsequent tests revealed that the build and dataload phases can
    complete successfully on Red Hat Linux v8.6 even in the absence of this
    package, so this patch removes the installation of snappy-devel during
    system preparation.
    
    Tested by running bin/bootstrap_system.sh on a newly minted private VM
    instance running RedHat Linux 8.6, then running
    buildall.sh -skiptests -format -testdata
    successfully.
    
    Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
    Reviewed-on: http://gerrit.cloudera.org:8080/20021
    Reviewed-by: Impala Public Jenkins <[email protected]>
    Tested-by: Impala Public Jenkins <[email protected]>
---
 bin/bootstrap_system.sh | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/bin/bootstrap_system.sh b/bin/bootstrap_system.sh
index 5a9186e5c..04d02e6bb 100755
--- a/bin/bootstrap_system.sh
+++ b/bin/bootstrap_system.sh
@@ -249,12 +249,6 @@ redhat sudo yum install -y curl gawk gcc gcc-c++ git 
krb5-devel krb5-server \
         net-tools langpacks-en glibc-langpack-en libxml2-devel libxslt-devel \
         java-${REDHAT_JAVA_VERSION}-openjdk-src 
java-${REDHAT_JAVA_VERSION}-openjdk-devel
 
-# Enable the Powertools repo for snappy-devel on RedHat 8
-redhat8 sudo yum install -y dnf-plugins-core
-# Package repo IDs changed from mixed case to all-lowercase between Centos 8.2
-# and 8.3, so use globbing to cover both conventions
-redhat8 sudo yum install -y --enablerepo="[Pp]ower[Tt]ools*" snappy-devel
-
 # RedHat / CentOS 8 exposes only specific versions of Python.
 # Set up unversioned default Python 2.x for older CentOS versions
 redhat6 sudo yum install -y python-devel python-setuptools python-argparse

Reply via email to