This is an automated email from the ASF dual-hosted git repository. dbecker pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit baddaf224126ac414a5fa6bac1c1e148633399b9 Author: Riza Suminto <[email protected]> AuthorDate: Mon May 15 13:53:08 2023 -0700 IMPALA-12144: Skip TestTpcdsQueryWithProcessingCost if dockerised There is a sign of flakiness in TestTpcdsQueryWithProcessingCost within dockerised environment. The flakiness seems to happen due to tighter per-process memory limit in dockerised environment. This patch skip TestTpcdsQueryWithProcessingCost in dockerised environment. Testing: - Hack SkipIfDockerizedCluster.insufficient_mem_limit to return True if IS_HDFS and confirm that the whole TestTpcdsQueryWithProcessingCost is skipped. Change-Id: Ibb6b2d4258a2c6613d1954552f21641b42cb3c38 Reviewed-on: http://gerrit.cloudera.org:8080/19892 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/common/skip.py | 2 ++ tests/query_test/test_tpcds_queries.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/common/skip.py b/tests/common/skip.py index 48d03946d..cdd96a801 100644 --- a/tests/common/skip.py +++ b/tests/common/skip.py @@ -173,6 +173,8 @@ class SkipIfDockerizedCluster: IS_DOCKERIZED_TEST_CLUSTER, reason="Daemon would need to access host filesystem.") insert_acls = pytest.mark.skipif(IS_DOCKERIZED_TEST_CLUSTER, reason="IMPALA-8384: insert ACL tests are broken on dockerised minicluster.") + insufficient_mem_limit = pytest.mark.skipif( + IS_DOCKERIZED_TEST_CLUSTER, reason="Test require high per-process mem_limit.") jira = partial(pytest.mark.skipif, IS_DOCKERIZED_TEST_CLUSTER) diff --git a/tests/query_test/test_tpcds_queries.py b/tests/query_test/test_tpcds_queries.py index 8d07d4241..cdfc39bac 100644 --- a/tests/query_test/test_tpcds_queries.py +++ b/tests/query_test/test_tpcds_queries.py @@ -21,6 +21,7 @@ from __future__ import absolute_import, division, print_function import pytest from tests.common.impala_test_suite import ImpalaTestSuite +from tests.common.skip import SkipIfDockerizedCluster from tests.common.test_dimensions import ( create_single_exec_option_dimension, is_supported_insert_format) @@ -743,6 +744,7 @@ class TestTpcdsUnmodified(ImpalaTestSuite): self.run_test_case('tpcds-q89', vector) [email protected]_mem_limit class TestTpcdsQueryWithProcessingCost(TestTpcdsQuery): @classmethod def get_workload(cls):
