This is an automated email from the ASF dual-hosted git repository. wzhou pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 95d21872e3281988c5495136eba6fc5f2585b8de Author: Surya Hebbar <[email protected]> AuthorDate: Wed May 10 09:37:21 2023 +0530 IMPALA-12133: Fix query timeline display height for compact query plans The patch resizes the fragment diagram for small query plans on the query timeline, eliminating unnecessary spacing below it. Lowest value of display_height and fragment diagram's height are taken by multiplying row_height and rownum. Constant folding implementations in browsers guarantee optimal rendering without performance degradation. Change-Id: I5e4123c54a2b8d9d2900b3271b274cd23e337c91 Reviewed-on: http://gerrit.cloudera.org:8080/19872 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Kurt Deschler <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> --- www/query_timeline.tmpl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/query_timeline.tmpl b/www/query_timeline.tmpl index 6e7d903ea..ad4f057cd 100644 --- a/www/query_timeline.tmpl +++ b/www/query_timeline.tmpl @@ -340,7 +340,8 @@ function renderTiming(ignored_arg) { timeticks_footer.innerHTML = ""; var row_height = 15; - var display_height = window.innerHeight - timing_diagram.offsetTop - 70; + var display_height = Math.min(window.innerHeight - timing_diagram.offsetTop - 70, + rownum * row_height); fragment_diagram.parentNode.style.height = display_height * 1 + "px"; fragment_diagram.setAttribute("height", rownum * row_height + "px");
