This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new ac341c01c IMPALA-11801: Use thrift 0.11.0 in FE when compiling with
Apache Hive3
ac341c01c is described below
commit ac341c01cc446e3e90a17963d47ef20bff8d4b43
Author: stiga-huang <[email protected]>
AuthorDate: Thu Jan 5 08:04:32 2023 +0800
IMPALA-11801: Use thrift 0.11.0 in FE when compiling with Apache Hive3
HMS client of Apache Hive3 can't run on thrift versions >= 0.14. Impala
fails to start when compiling with Apache Hive3. This patch switches
back to the old thrift version (0.11.0) used in FE when compiling on
Apache Hive3.
Tests:
- Compiled and launched Impala cluster on Apache Hive3.
- Verified some simple queries.
- Enabling all the tests will be continued in IMPALA-10871.
Change-Id: Idcdae97920241429c6dd0bd2b4ac1debfbde9d23
Reviewed-on: http://gerrit.cloudera.org:8080/19400
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
bin/impala-config.sh | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 8cfdac0ad..2d2ce7175 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -72,6 +72,10 @@ fi
# mvn versions:set -DnewVersion=YOUR_NEW_VERSION
export IMPALA_VERSION=4.3.0-SNAPSHOT
+# Whether to build on Apache Hive (or CDP Hive). Versions of some toolchain
dependencies
+# (e.g. thrift) will also depend on this.
+export USE_APACHE_HIVE=${USE_APACHE_HIVE-false}
+
# The unique build id of the toolchain to use if bootstrapping. This is
generated by the
# native-toolchain build when publishing its build artifacts. This should be
changed when
# moving to a different build of the toolchain, e.g. when a version is bumped
or a
@@ -180,8 +184,14 @@ unset IMPALA_CALLONCEHACK_URL
# with Impyla and for the thrift compiler.
export IMPALA_THRIFT_CPP_VERSION=0.16.0-p3
unset IMPALA_THRIFT_CPP_URL
-export IMPALA_THRIFT_POM_VERSION=0.16.0
-export IMPALA_THRIFT_JAVA_VERSION=${IMPALA_THRIFT_POM_VERSION}-p3
+if $USE_APACHE_HIVE; then
+ # Apache Hive 3 clients can't run on thrift versions >= 0.14 (IMPALA-11801)
+ export IMPALA_THRIFT_POM_VERSION=0.11.0
+ export IMPALA_THRIFT_JAVA_VERSION=${IMPALA_THRIFT_POM_VERSION}-p5
+else
+ export IMPALA_THRIFT_POM_VERSION=0.16.0
+ export IMPALA_THRIFT_JAVA_VERSION=${IMPALA_THRIFT_POM_VERSION}-p3
+fi
unset IMPALA_THRIFT_JAVA_URL
export IMPALA_THRIFT_PY_VERSION=0.11.0-p5
unset IMPALA_THRIFT_PY_URL
@@ -316,7 +326,6 @@ export IMPALA_TEZ_VERSION=${CDP_TEZ_VERSION}
export IMPALA_TEZ_URL=${CDP_TEZ_URL-}
export APACHE_COMPONENTS_HOME="$IMPALA_TOOLCHAIN/apache_components"
-export USE_APACHE_HIVE=${USE_APACHE_HIVE-false}
if $USE_APACHE_HIVE; then
# When USE_APACHE_HIVE is set we use the apache hive version to build as
well as deploy
# in the minicluster
