This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch branch-4.1.1 in repository https://gitbox.apache.org/repos/asf/impala.git
commit f61f21a2d4c81ba65eed6051ce0d39d285a27e97 Author: stiga-huang <[email protected]> AuthorDate: Thu Jun 23 21:06:53 2022 +0800 IMPALA-9823: Make use_local_catalog and related flags visible use_local_catalog and related flags shouldn't be hidden and should be show up on the Web UI. This makes them visible. Also updates the description of use_local_catalog. Change-Id: Ic5a39321b1fee4bc34266f235ee2dd1374778083 Reviewed-on: http://gerrit.cloudera.org:8080/18660 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/19128 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Quanlong Huang <[email protected]> --- be/src/runtime/exec-env.cc | 13 +++++++------ tests/common/environ.py | 1 - 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/be/src/runtime/exec-env.cc b/be/src/runtime/exec-env.cc index 8a78d3524..dea2e3c35 100644 --- a/be/src/runtime/exec-env.cc +++ b/be/src/runtime/exec-env.cc @@ -100,21 +100,22 @@ DEFINE_int32(admission_control_slots, 0, "that it needs. Defaults to number of cores / -num_cores for executors, and 8x that " "value for dedicated coordinators)."); -DEFINE_bool_hidden(use_local_catalog, false, - "Use experimental implementation of a local catalog. If this is set, " - "the catalog service is not used and does not need to be started."); -DEFINE_int32_hidden(local_catalog_cache_mb, -1, +DEFINE_bool(use_local_catalog, false, + "Use the on-demand metadata feature in coordinators. If this is set, coordinators " + "pull metadata as needed from catalogd and cache it locally. The cached metadata " + "gets evicted automatically under memory pressure or after an expiration time."); +DEFINE_int32(local_catalog_cache_mb, -1, "If --use_local_catalog is enabled, configures the size of the catalog " "cache within each impalad. If this is set to -1, the cache is auto-" "configured to 60% of the configured Java heap size. Note that the Java " "heap size is distinct from and typically smaller than the overall " "Impala memory limit."); -DEFINE_int32_hidden(local_catalog_cache_expiration_s, 60 * 60, +DEFINE_int32(local_catalog_cache_expiration_s, 60 * 60, "If --use_local_catalog is enabled, configures the expiration time " "of the catalog cache within each impalad. Even if the configured " "cache capacity has not been reached, items are removed from the cache " "if they have not been accessed in this amount of time."); -DEFINE_int32_hidden(local_catalog_max_fetch_retries, 40, +DEFINE_int32(local_catalog_max_fetch_retries, 40, "If --use_local_catalog is enabled, configures the maximum number of times " "the frontend retries when fetching a metadata object from the impalad " "coordinator's local catalog cache."); diff --git a/tests/common/environ.py b/tests/common/environ.py index e62eb87c3..5f69d92a8 100644 --- a/tests/common/environ.py +++ b/tests/common/environ.py @@ -368,7 +368,6 @@ class ImpalaTestClusterProperties(object): """Checks whether we use local catalog.""" try: key = "use_local_catalog" - # --use_local_catalog is hidden so does not appear in JSON if disabled. return key in self.runtime_flags and self.runtime_flags[key]["current"] == "true" except Exception: if self.is_remote_cluster():
