This is an automated email from the ASF dual-hosted git repository.
krishvishal pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/master by this push:
new b03978e9f ci: collapse status into finalize_pr, fix cancel hang (#3282)
b03978e9f is described below
commit b03978e9f9bda6d8d844babbd5bbcd9c35e32a6c
Author: Hubert Gruszecki <[email protected]>
AuthorDate: Tue May 19 11:25:18 2026 +0200
ci: collapse status into finalize_pr, fix cancel hang (#3282)
`status` aggregated test results and built CI Summary;
`finalize_pr` only re-checked status.result and exited 0/1,
adding a second runner per PR with no extra signal. ASF
branch protection (.asf.yaml) requires context `finalize_pr`
as the sole required check on master. Rename `status` ->
`finalize_pr` and drop `name: CI Status` so GitHub resolves
the context from the job key. Delete the old pass-through.
Job-level `if: always()` re-evaluates after cancel-in-progress
fires, schedules itself, and waits indefinitely for a runner
that never arrives, holding the concurrency lock and blocking
the next PR push for tens of minutes. Replace with
`!cancelled()` on all aggregator/release jobs (pre-merge
finalize_pr, _common.yml summary, publish-docker,
docker-manifests, publish, release final aggregator).
Step-level `always()` untouched (no phantom-queue risk).
---
.github/workflows/_common.yml | 2 +-
.github/workflows/pre-merge.yml | 19 ++-----------------
.github/workflows/publish.yml | 8 ++++----
3 files changed, 7 insertions(+), 22 deletions(-)
diff --git a/.github/workflows/_common.yml b/.github/workflows/_common.yml
index 4c9181646..f7129b6fc 100644
--- a/.github/workflows/_common.yml
+++ b/.github/workflows/_common.yml
@@ -280,7 +280,7 @@ jobs:
binary-artifacts,
typos,
]
- if: always()
+ if: ${{ !cancelled() }}
runs-on: ubuntu-latest
steps:
- name: Summary
diff --git a/.github/workflows/pre-merge.yml b/.github/workflows/pre-merge.yml
index 1e9d5312d..5a7deb3ee 100644
--- a/.github/workflows/pre-merge.yml
+++ b/.github/workflows/pre-merge.yml
@@ -191,11 +191,10 @@ jobs:
task: ${{ matrix.task }}
# Final status check
- status:
- name: CI Status
+ finalize_pr:
runs-on: ubuntu-latest
needs: [common, detect, test-rust, test-python, test-node, test-go,
test-java, test-csharp, test-cpp, test-bdd, test-examples, test-other]
- if: always()
+ if: ${{ !cancelled() }}
steps:
- name: Get job execution times
id: times
@@ -439,17 +438,3 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY
echo "✅ **CI Passed** - All checks completed successfully!" >>
$GITHUB_STEP_SUMMARY
fi
-
- finalize_pr:
- runs-on: ubuntu-latest
- needs:
- - status
- if: always()
- steps:
- - name: Everything is fine
- if: ${{ !(contains(needs.*.result, 'failure')) }}
- run: exit 0
-
- - name: Some tests failed
- if: ${{ contains(needs.*.result, 'failure') }}
- run: exit 1
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 1095c6767..1830a4f43 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -733,7 +733,7 @@ jobs:
name: Docker ${{ matrix.name }} (${{ matrix.arch }})
needs: [validate, plan, check-tags, build-python-wheels,
publish-rust-crates]
if: |
- always() &&
+ !cancelled() &&
needs.validate.outputs.has_targets == 'true' &&
needs.plan.outputs.has_docker == 'true' &&
fromJson(needs.plan.outputs.docker_matrix).include[0].key != 'noop' &&
@@ -837,7 +837,7 @@ jobs:
name: Docker manifests
needs: [validate, plan, publish-docker]
if: |
- always() &&
+ !cancelled() &&
needs.validate.outputs.has_targets == 'true' &&
needs.plan.outputs.has_docker == 'true' &&
fromJson(needs.plan.outputs.docker_components).include[0].key != 'noop'
&&
@@ -1040,7 +1040,7 @@ jobs:
name: ${{ matrix.name }}
needs: [validate, plan, check-tags, build-python-wheels,
publish-rust-crates]
if: |
- always() &&
+ !cancelled() &&
needs.validate.outputs.has_targets == 'true' &&
fromJson(needs.plan.outputs.non_docker_targets).include[0].key != 'noop'
&&
(needs.build-python-wheels.result == 'success' ||
needs.build-python-wheels.result == 'skipped') &&
@@ -1350,7 +1350,7 @@ jobs:
docker-manifests,
publish,
]
- if: always() && needs.validate.outputs.has_targets == 'true'
+ if: ${{ !cancelled() && needs.validate.outputs.has_targets == 'true' }}
runs-on: ubuntu-latest
steps:
- name: Download latest copy script from master
