saie-ch commented on PR #2973: URL: https://github.com/apache/iggy/pull/2973#issuecomment-4452113983
> @saie-ch I noticed that comments from this PR are not fixed (output from claude code): > > ``` > #: 2958694591 > Reviewer: atharvalade > Location: access_token.go:36 > Ask: Expiry field → uint64, use PutUint64 (current PutUint32 writes expiry into high 32 bits → server reads expiry << 32) > Status: ❌ NOT fixed — file never touched. Line 24 still uint32, line 36 still PutUint32 > ──────────────────────────────────────── > #: 2958698450 > Reviewer: atharvalade > Location: user.go:77 (CreateUser) > Ask: nil-permissions branch must also write permissions_len:u32_le=0 > Status: ❌ NOT fixed — else branch still writes only 1 flag byte; capacity has no +4 for nil case > ──────────────────────────────────────── > #: 2958701940 > Reviewer: atharvalade > Location: user.go UpdatePermissions > Ask: base length = len(userIdBytes)+1+4; else branch must write 4 zero bytes > Status: ❌ NOT fixed — line 119 still len(userIdBytes)+1, else branch line 142 still single 0 byte. Code untouched > ──────────────────────────────────────── > #: 2962372305 > Reviewer: chengxilo > Location: update_user.go:43 > Ask: stop mutating receiver u.Username > Status: ❌ NOT fixed — lines 39-43 still assign u.Username = new(string) then deref > ``` > > can you fix them? > > /author thanks @hubcio , will try to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
