ex172000 opened a new pull request, #3245: URL: https://github.com/apache/iggy/pull/3245
Continues / supersedes #3063, which was auto-closed due to inactivity. The branch was force-pushed (rebase on current `master` plus a new fixup commit), so GitHub does not allow reopening the original PR. ## Which issue does this PR close? Related to #1986 ## What changed? The four commits on this branch add a shared Gherkin feature file for stream CRUD operations and corresponding `godog` step definitions, then layer in `update`/`delete` for streams across all SDKs. The new commit on top addresses the remaining review feedback from #3063: - **chengxilo:** `thenStreamDeletedSuccessfully` now verifies via `GetStream` against the server instead of checking a local pointer that `whenDeleteStream` itself set to nil. - **chengxilo:** anchored all `sc.Step` regexes in `bdd/go/tests/basic_messaging.go` with `^...$` for consistency. - **chengxilo:** kept the per-scenario `After` cleanup but documented it as best-effort, with a note that a global cleanup script is the better long-term direction. - **hubcio:** made the stream-delete step explicit in the shared feature file (`When I delete the stream with name "..."`) instead of relying on implicit prior-step state. Updated the Go, Rust, Python, Java, C#, and Node step definitions to match. ## Local Execution - Branch rebased on current `master`. - `go vet ./tests/...` and `go test -count=0 ./tests/...` pass for `bdd/go`. - Pre-commit hooks pass (`golangci-lint` and `csharp-dotnet-format` were skipped locally due to toolchain gaps — `golangci-lint` pinned at v1.64.8 (Go 1.23) cannot lint a Go 1.25 project, and `dotnet` is not on this machine; CI will exercise both properly). ## AI Usage 1. Which tools? Claude Code 2. Scope of usage? Generate functions under supervision and planning 3. How did you verify the generated code works correctly? Build/vet on Go side, manual diff review on the other SDKs 4. Can you explain every line of the code if asked? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
