jpds commented on PR #3233: URL: https://github.com/apache/iggy/pull/3233#issuecomment-4430658703
> also: will the compilation for macos with feature systemd fail? or is systemd crate portable and uses some macos mechanism? sd-notify itself is pure Rust, there's no libsystemd linkage, so `--features systemd` would compile fine on macOS; and then just no-op at runtime since no notification socket is set. I've adjusted the code to address the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
