hubcio commented on code in PR #3235:
URL: https://github.com/apache/iggy/pull/3235#discussion_r3225393840
##########
.github/workflows/pre-merge.yml:
##########
@@ -78,6 +78,19 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+ # PHP SDK
+ test-php:
+ name: PHP • ${{ matrix.task }}
+ needs: detect
+ if: ${{ fromJson(needs.detect.outputs.php_matrix).include[0].component !=
'noop' }}
+ strategy:
+ fail-fast: false
+ matrix: ${{ fromJson(needs.detect.outputs.php_matrix) }}
+ uses: ./.github/workflows/_test.yml
+ with:
+ component: ${{ matrix.component }}
+ task: ${{ matrix.task }}
+
Review Comment:
BTW: PHP test in CI took 22 minutes, which is unacceptable. It has to be
below 10 minutes.
<img width="1124" height="152" alt="image"
src="https://github.com/user-attachments/assets/a0d14caa-8665-41a3-9b8d-4d1af90f855b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
