Standing-Man commented on PR #3152:
URL: https://github.com/apache/iggy/pull/3152#issuecomment-4387616521
Hi @hubcio, thank you very much for your detailed review. I’ve addressed the
following issues in the latest commit:
1. Strengthened `validate_api_url` behavior
* Switched the port check to port_or_known_default() so default ports
are treated as valid
* Added explicit rejection for `:0` `(api_url.port() == Some(0))`
* Kept strict rejection for `userinfo/path/query/fragment` components
2. Added URL validation not only in the builders, but also in the
constructors.
3. Added corresponding tests for the `TCP` and `QUIC` builders.
4. Replaced `reqwest::Url` usage with `url::Url`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
