hubcio commented on code in PR #3194:
URL: https://github.com/apache/iggy/pull/3194#discussion_r3180704475
##########
core/connectors/sdk/src/lib.rs:
##########
@@ -425,4 +425,16 @@ pub enum Error {
/// failures so that circuit breakers are not tripped by bad data.
#[error("Permanent HTTP error: {0}")]
PermanentHttpError(String),
+ /// The source schema could not be mapped to the destination schema.
+ /// Indicates a table definition or configuration problem
+ #[error("Schema mismatch: {0}")]
+ SchemaMismatch(String),
+ /// An I/O failure while writing data (e.g. Parquet serialization, file
+ /// writer close). Distinct from record-level validation errors.
+ #[error("Write failure: {0}")]
+ WriteFailure(String),
+ /// A catalog or transaction-level failure (e.g. applying or committing an
+ /// Iceberg transaction). Callers may retry on transient catalog outages.
Review Comment:
doc "callers may retry on transient catalog outages" is misleading.
`action.apply()` at `router/mod.rs:213` is in-memory transaction prep -
deterministic failures (invalid partition spec, schema validation) cannot be
retried. only `tx.commit(catalog)` at `router/mod.rs:222` hits the network.
suggest dropping the retry claim, or splitting into `ApplyError`
(deterministic) vs `CommitError` (transient-eligible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
