kriti-sc commented on code in PR #3180:
URL: https://github.com/apache/iggy/pull/3180#discussion_r3177104908
##########
core/connectors/runtime/src/sink.rs:
##########
@@ -591,6 +591,100 @@ async fn process_messages(
messages.as_ptr(),
messages.len(),
);
+ if status != 0 {
+ return Err(RuntimeError::SinkConsumeFailed {
+ plugin_id,
+ status,
+ stream: topic_metadata.stream.clone(),
+ topic: topic_metadata.topic.clone(),
+ partition_id: messages_metadata.partition_id,
+ current_offset: messages_metadata.current_offset,
+ schema: messages_metadata.schema.to_string(),
+ messages_count: processed_count,
Review Comment:
We should aim for consistency here as messages_count & processed_count mean
different things in Iggy. The field name should be renamed to `processed_count`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
