seokjin0414 commented on PR #3046: URL: https://github.com/apache/iggy/pull/3046#issuecomment-4359129204
on the review-body items: - new_connection ownership: added `# Ownership` / `# Safety` doc sections covering double-free, use-after-free, and threading. - logout TODO: dropped — `Box::from_raw` runs unconditionally, no leak path. left a one-liner instead. - `enable_all()` fragility: pinned tokio features in `foreign/cpp/Cargo.toml` (`rt-multi-thread, macros, time, net, io-util`) so it doesn't ride on sdk transitives. - identifier magic-number audit: out of scope here, will open a separate PR. - `polled.partition_id` assertions: added to round-trip / specific-partition / no-partition tests — catches the `u32::MAX` sentinel regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
