chengxilo commented on code in PR #3166:
URL: https://github.com/apache/iggy/pull/3166#discussion_r3165780501
##########
foreign/go/binary_serialization/binary_response_deserializer.go:
##########
@@ -157,7 +157,7 @@ func DeserializeFetchMessagesResponse(payload []byte,
compression iggcon.IggyMes
}
payloadSlice, err = s2.Decode(nil, payloadSlice)
if err != nil {
- panic("iggy: failed to decode s2 payload: " +
err.Error())
+ return nil, fmt.Errorf("iggy: failed to decode
s2 payload: %w", err)
Review Comment:
nit
```suggestion
return nil, fmt.Errorf("failed to decode s2
payload: %w", err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
