numinnex commented on PR #3099: URL: https://github.com/apache/iggy/pull/3099#issuecomment-4343566753
Thanks a lot for taking the time to put this together. I really appreciate the effort and thought behind it. That said, I’m going to hold off on merging this for now. We’re currently in the process of redesigning this part of the system for the upcoming clustered version of the server, which should land in roughly the next month. In the current implementation, we handle deduplication by storing a message_id and checking server-side whether it already exists. In the clustered setup, this approach is being replaced with a different mechanism: clients will provide a monotonically increasing request_id, and deduplication will be based on that (similar in spirit to how TCP handles packet deduplication). Because of this shift, the changes in this PR would likely be short-lived and would need to be reworked or removed shortly after merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
