atharvalade opened a new issue, #3171:
URL: https://github.com/apache/iggy/issues/3171

   The `handle_messages` function in `core/connectors/sdk/src/source.rs` 
discards the actual error returned by `source.poll()`:
   
   ```rust
   let Ok(messages) = messages else {
       error!("Failed to poll messages for source connector with ID: 
{plugin_id}");
       continue;
   };
   ```
   
   The underlying error is never logged. Any connector failure produces an 
infinite loop of "Failed to poll messages" with zero context about the root 
cause. During the Postgres-to-Iceberg benchmark, this cost significant 
debugging time because the real error (`InvalidRecord` from a NUMERIC column 
type mismatch) was invisible until a temporary log line was added inside the 
connector's own `poll()` method.
   
   **Fix**: Log the error: `error!("Failed to poll messages for source 
connector with ID: {plugin_id}: {err:?}");`
   
   The same pattern should be checked in the sink SDK path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to