numinnex commented on code in PR #3151:
URL: https://github.com/apache/iggy/pull/3151#discussion_r3122358256
##########
core/common/src/traits/consumer_offset_client.rs:
##########
@@ -53,4 +54,34 @@ pub trait ConsumerOffsetClient {
topic_id: &Identifier,
partition_id: Option<u32>,
) -> Result<(), IggyError>;
+
Review Comment:
We don't want those methods to be part of the SDK traits, as they are not
supported by the current `server`, instead it has to be stashed together
similarly to new `SendMessages` command, where it exists as a new command in
the `binary_protocol` crate, but the only user of it is the `simulator` client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
