Standing-Man opened a new pull request, #3142: URL: https://github.com/apache/iggy/pull/3142
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes # ## Rationale <!-- Why is this change needed? If the issue explains it well, a one-liner is fine. --> This PR makes environment variable suggestions deterministic in TypedEnvProvider. When multiple candidate env vars have the same Levenshtein distance to an unknown variable, the previous implementation could return them in non-deterministic order (due to HashSet iteration). This change adds a stable tie-breaker so suggestions are consistently ordered. ## What changed? <!-- 2-4 sentences. Problem first (before), then solution (after). GOOD: "Messages were unavailable when background message_saver committed the journal and started async disk I/O before completion. Polling during this window found neither journal nor disk data. The fix freezes journal batches in the in-flight buffer before async persist." GOOD: "When many small messages accumulate in the journal, the flush passes thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)." BAD: - Walls of text - "This PR adds..." (we can see the diff) --> Sorting logic now: 1. Sort by edit distance (ascending) 2. Tie-break by variable name (lexicographical ascending) Added test `find_similar_vars_has_deterministic_order_for_same_distance` that verifies stable output order for same-distance candidates. ## Local Execution - Passed / not passed Passed - Pre-commit hooks ran / not ran ran <!-- You must run your code locally before submitting. "Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed. Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md). --> ## AI Usage <!-- If AI tools were used, please answer: 1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT) 2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation) 4. How did you verify the generated code works correctly? 5. Can you explain every line of the code if asked? If no AI tools were used, write "None" or delete this section. --> I used codex to check the code I wrote. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
