atharvalade opened a new pull request, #3135:
URL: https://github.com/apache/iggy/pull/3135

   ## Which issue does this PR close?
   
   Closes #3132
   
   ## Rationale
   
   An operator accidentally placing a file (e.g. `.DS_Store`, editor swap file, 
backup) in the consumer offsets directory crashes the server on startup due to 
a `panic!` on non-numeric filenames.
   
   ## What changed?
   
   Both `load_consumer_offsets` and `load_consumer_group_offsets` in 
`core/server/src/streaming/partitions/storage.rs` panicked when encountering 
files with non-numeric names during startup offset loading.
   
   The fix replaces both `panic!` calls with `warn!` log messages and 
`continue`, so the server gracefully skips unexpected files. Added 9 unit tests 
covering valid files, non-numeric files (`.DS_Store`, `backup.bak`), empty 
directories, subdirectories, and nonexistent paths for both functions.
   
   ## Local Execution
   
   - Passed
   - Pre-commit hooks ran
   
   ## AI Usage
   
   1. Opus 4.6
   2. Minimal AI used
   3. All tests verified locally with `cargo test`, `cargo clippy`, `cargo fmt 
--check`, and CI scripts
   4. Yes, all code can be explained


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to