sujitn opened a new pull request, #3101:
URL: https://github.com/apache/iggy/pull/3101
The offset assigned during append was computed but discarded. Propagate it
through ShardResponse::SendMessages and include it in the binary protocol
response.
Wire format change:
Before: [status:4 LE][length:4 LE (0)]
After: [status:4 LE][length:4 LE (12)][base_offset:8 LE][partition_id:4
LE]
existing SDK clients read the length field and skip unknown body bytes. The
send_messages wrapper discards the response body and returns Ok(()).
Ref: https://github.com/apache/iggy/discussions/3044
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
If AI tools were used, please answer:
1. Which tools?
Claude
2. Scope of usage?
SDK validation
3. How did you verify the generated code works correctly?
- 64/64 server unit tests pass (cargo test -p server --lib)
- 36/36 offset retrieval integration tests pass, these send messages via
the SDK
- 87/87 concurrent produce/consume integration tests pass
- 6/6 authentication integration tests pass
- cargo clippy -p server --all-targets -- -D warnings - 0 warnings
4. Can you explain every line of the code if asked?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
