krishvishal commented on code in PR #3092:
URL: https://github.com/apache/iggy/pull/3092#discussion_r3063733287
##########
core/shard/src/router.rs:
##########
@@ -79,6 +97,12 @@ where
0
})
} else {
+ // TODO: View change messages (StartViewChange, DoViewChange,
StartView) return
+ // Operation::Reserved, so they always land here and route to
shard 0. This is
+ // correct only in single-shard deployments. In multi-shard,
partition-plane view
+ // change messages must reach the shard owning that consensus
group. Fixing this
+ // requires routing by Command2 + consensus namespace (a u64)
rather than by
+ // Operation + IggyNamespace, since view change headers don't
carry an IggyNamespace.
0
};
let _ = self.senders[target as
usize].send(ShardFrame::fire_and_forget(generic));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
