numinnex commented on code in PR #3071:
URL: https://github.com/apache/iggy/pull/3071#discussion_r3052783603
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -191,7 +451,10 @@ impl Partition for IggyPartition {
if args.auto_commit && !fragments.is_empty() {
let last_offset =
last_matching_offset.expect("non-empty poll result must have a
last offset");
- if let Err(err) = self.store_consumer_offset(consumer,
last_offset) {
+ if let Err(err) = self
Review Comment:
I think for auto commit polls, at the end of the `command_handler` construct
new `Message<Prepare>`, with `StoreConsumerOffset` command and run it through
the `on_message` handler, the same way an `StoreConsumerOffset` client request
would.
Additionally I think we should expand the `StoreConsumerOffset` command to
allow for different levels of consistency such as `no_ack` or `quorum`,
something that `kafka` does for `SendMessages`. This way the `auto_commit` from
`PollMessages` command, could inherit that aswell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
