gomnitrix commented on code in PR #3045:
URL: https://github.com/apache/iggy/pull/3045#discussion_r3047563734
##########
core/integration/tests/connectors/fixtures/iceberg/container.rs:
##########
@@ -532,3 +535,39 @@ impl TestFixture for IcebergPreCreatedFixture {
self.inner.connectors_runtime_envs()
}
}
+
+pub struct IcebergEnvAuthFixture {
+ inner: IcebergPreCreatedFixture,
+}
+
+impl IcebergOps for IcebergEnvAuthFixture {
+ fn catalog_url(&self) -> &str {
+ self.inner.catalog_url()
+ }
+
+ fn http_client(&self) -> &HttpClient {
+ self.inner.http_client()
+ }
+}
+
+#[async_trait]
+impl TestFixture for IcebergEnvAuthFixture {
+ async fn setup() -> Result<Self, TestBinaryError> {
+ let inner = IcebergPreCreatedFixture::setup().await?;
+ // Set credentials before test server initialization.
+ unsafe {
Review Comment:
Yes, this is a serious issue. I missed the concurrency risks while trying to
figure out how the test environment handles variables. I'll spend more time
digging into the implementation to avoid similar mistakes in the future. I've
fixed it and thanks for the heads-up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
