chengxilo commented on code in PR #3063:
URL: https://github.com/apache/iggy/pull/3063#discussion_r3034343212
##########
bdd/go/tests/basic_messaging.go:
##########
@@ -322,10 +363,20 @@ func initBasicMessagingScenario(sc
*godog.ScenarioContext) {
sc.Step(`the topic should be created successfully`,
s.thenTopicCreatedSuccessfully)
sc.Step(`^the topic should have name "([^"]*)"$`, s.thenTopicHasName)
sc.Step(`^the topic should have (\d+) partitions$`,
s.thenTopicsHasPartitions)
+ sc.Step(`^I update the stream name to "([^"]*)"$`,
s.whenUpdateStreamName)
+ sc.Step(`^the stream name should be updated to "([^"]*)"$`,
s.thenStreamNameUpdated)
+ sc.Step(`I delete the stream`, s.whenDeleteStream)
+ sc.Step(`the stream should be deleted successfully`,
s.thenStreamDeletedSuccessfully)
Review Comment:
I recommend `^...$` for consistency. e.g. `^I delete the stream$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
