tmchow commented on PR #3051: URL: https://github.com/apache/iggy/pull/3051#issuecomment-4155999080
Good catch, you're right — `rename_all = "snake_case"` changes the serialization output from PascalCase to snake_case, which breaks the HTTP API wire format that all foreign SDKs depend on. Fixed by replacing `rename_all` with per-variant `#[serde(alias = "...")]` attributes. This preserves PascalCase in serialization output (so `HttpMessageStream.cs` and all other SDKs continue to work unchanged) while accepting snake_case during deserialization. The `Display`/`FromStr` impls already handle snake_case for the CLI path independently. Checked the other enums in the codebase (`UserStatus`, `ConsumerKind`, etc.) that use `rename_all` — those don't have the same cross-SDK exposure since they're not used in the `/snapshot` HTTP endpoint the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
