lukaszzborek commented on code in PR #3040:
URL: https://github.com/apache/iggy/pull/3040#discussion_r3006838580
##########
foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs:
##########
@@ -380,11 +382,19 @@ private async Task PollMessagesAsync(CancellationToken ct)
try
{
var decryptedPayload =
_config.MessageEncryptor.Decrypt(message.Payload);
+
Review Comment:
i see it's not covered by tests. I think it will be good to add some
integration tests which check it.
It might be single tests for Producer and Consumer client or seperate test.
somthink like:
1. create iggyProducer
2. send encrypted message
3. create 'normal' client;
4. poll this message from topic
5. asset that headers was not decrypted
6. manual decrypt header and check if it is valid
and for iggyConsumer
... send encrypted message
4. poll message via IggyConsumer client with decryptor
5. validate if headers was decrypted property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
