atharvalade commented on PR #3037: URL: https://github.com/apache/iggy/pull/3037#issuecomment-4138063532
> Though I do not have experience writing go, I feel that the actual implementation files and the test files are getting mixed up, with only *_test.go indicating whether something is a test file or not. I saw that there is a `tests/` folder in `foreign/go`. Wouldn't shifting these files into `tests/` make more sense? thanks for the review, that's a great thought, but in Go the standard convention is to co-locate `*_test.go` files alongside the package they test... this is how the Go `stdlib`, Kubernetes, and Docker all do it, and it enables white-box testing of unexported internals. The existing `foreign/go/tests/` directory specifically holds integration/e2e tests that need a running server, so the separation is already intentional. @slbotbm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
