mlevkov commented on PR #2925: URL: https://github.com/apache/iggy/pull/2925#issuecomment-4119679077
> looking very good, I found only one nit: you moved `owned_value_to_serde_json` to connectors SDK but you didn't use it in `elasticsearch_sink`. there is duplicate code. please use it :) > > after you fix that we can merge. also, please fix CI - there were some changes in the `binary_protocol` crate, looks like tests fail after rebase. @hubcio Originally, I did, but since I was not a maintainer of Elasticsearch connector I chose not to touch it, however, now that you mention I will do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
