chengxilo commented on PR #3015: URL: https://github.com/apache/iggy/pull/3015#issuecomment-4112316450
> > @saie-ch so why these tests passed? do those commits overlap? > > @hubcio Thanks for the question! Could you clarify which tests you're referring to? For context: The tests passed in #2973 because the bugs were already fixed in that same PR As per @chengxilo review comment, we separated the bug fixes into this PR first Also I think the tests @hubcio refering to is the tests you implemented for command. As those tests passed it bascially means they didn't detect the bug in `iggon.Permission` , that's why @hubcio and @ryankert01 are requesting you to add a test, because we don't have a proper test for the `iggon.Permission`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
